Stat Priorities
Item level or Intellect value should not be understated, especially early in an expansion. Very often, if it's a significant item level upgrade (13+ item level) then it will be a DPS upgrade to wear it regardless of the stats. As always, sim yourself with Raidbots.com for an accurate assessment of what gear to put on.
In Patch 10.2 all stats scale well with Demonology’s toolkit, even versatility is back as a relevant stat and should be overlooked. The only change that early sims seem to indicate from 10.1.7 is that haste stacking is not as powerful as it used to be for Demonology. Try to lean into a more balanced stat setup if you have the choice without lowering item level, and use enchants, gems and weapon runes to add to whatever stat you are in need of.
Demonbolt Builds (Sacrificed Souls talented):
Intellect >> Crit = Vers > Haste > Mastery
Non-Demonbolt builds:
Intellect > whatever your sims tell you (there really is no better answer sorry)
Stat Outline
Intellect is just a flat damage increase to all your abilities.
Ultimately it just comes down to damage per point, but here is an outline of what the stats do and how they interact with Demonology’s toolkit.
Haste: Increases casting/attack speed for both you and your pets. This is especially relevant for imps as they have a set amount of firebolts (6) and will time out faster with more haste. To offset this, you summon imps faster with more haste so it evens itself out in terms of rotational gameplay.
Mastery: Mastery increases all of your pets damage as well as implosion and Bilescourge Bombers (if talented).
Versatility: Gives damage to all your abilities, and half of that damage bonus as damage reduction. In some situations you can choose to use a higher versatility gear setup to survive certain mechanics, although I doubt with the current state of warlock defensives, that this will be an issue outside of PvP.
Critical Strike: Crit does not interact with Demolology’s toolkit in any meaningful way and is just a chance to deal double damage. It is a more sought after stat for Demonbolt focused talent setups as the spell doesn't benefit from mastery.
The best way to calculate stat priorities for your character is to "sim" your character.
Races
The difference between the best and worst race is 1.6%. That being said, there is 1 “clear” winner for each faction
Horde: Tauren - 2% Critical Strike Damage
Alliance: Dwarf - 2% Critical Strike Damage
Enchants
Weapon: Sophic Devotion
Chest: Waking Stats
Legs: Frozen Spellthread
Bracers: Devotion of Avoidance / Devotion of Speed
Cloak: Graceful Avoidance / Homebound Speed
Boots: Plainsrunner’s Breeze
Rings: Devotion of Versatility
Belt: Shadowed Belt Clasp
Gems
Intellect/Crit: Inscribed Illimited Diamond safe option, but other gems can be slightly better depending on your current stats.(1)
Crit/Vers: Radiant Alexstrazite (might change depending on current stats)
Consumables
Food: Sizzling Seafood Medley or Grand Banquet of the Kalu’ak
Potion: Elemental Potion of Ultimate Power
Augment Rune: Draconic Augment Rune
Weapon Rune: Buzzing Rune (Can change depending on build/current gear)
Healthpot: Dreamwalker's Healing Potion
Additional Consumables: Pepsi Max for 5% DPS gain!
Phials (Flasks): Iced Phial of Corrupting Rage got buffed with 10.1 and now requires 400% of max hp to be taken in order to trigger the negative effect, greatly increasing its uptime. It is very likely that this flask will end up being the best choice. Phial of Elemental Chaos is a safe choice, but Phial of tepid versatility is not a poor choice and offers a small damage reduction as well.