Generally with most tanks you want Item level over all stats as more stamina and main stat will always be good. However when you are look at the same item level then the priority to look for should be:
- Item Level
- Critical Strike
As to what you should be running when you’re looking at min maxing your DPS then you should sim yourself as your weights will change based on your current gear.
Strength: This is your primary stat as a Protection Warrior and does a bit of everything. It increases your damage, the armor bonus granted by Vanguard, it increases your chance at parrying attacks and increases the size of your Ignore Pain shields.
Haste: Haste does a lot for a Protection Warriors, as well as decreasing the global cooldown, increasing your attack speed it also decreases the cooldown on Shield Slam and Thunder Clap and as our 2 main rage generating abilities is both good for damage and survivability. The most important thing of all however, is the reduction of Shield Block’s cooldown. This leaves less gaps in our active mitigation and overall smoothening the damage we take.
Versatility: This just increases all your damage and healing done while reducing all damage taken. This includes the healing done by your Ignore Pain.
Mastery: Our mastery is very strong for physical damage. Mastery: Critical Block increases our chance to block as well as our chance to critically block which blocks for twice the amount which is a huge damage reduction on pure physical abilities. In addition to this, mastery also increases our attack power which also increases the size of our Ignore Pain.
Critical Strike: This increases the chance for your spells to deal double damage. Additionally, as a tank, all critical strike grants your bonus parry chance which is really good for Protection Warrior as it is your primary passive mitigation.
So warriors are able to play every race in the game which if you care about your appearance is a great thing. However, here are some of the better races just from a pure min max PoV.
Undead: Touch of the Grave provides a nice amount of passive damage and healing on a single target. Will of the Forsaken gives you another version of Berserker Rage which allows you to remove sleep, charm and fear effects.
Blood elf: Arcane Torrent is nice to have as Warrior’s don’t have a way to purge.
Lightforged Draenei: Light's Judgment is a very strong on demand AoE DPS cooldown.
Night elf: If you’re interested in M+ Shadowmeld is invaluable at creating new ways to skip mobs.
Rings: You will enchant your rings with Enchant Ring - Tenet of Versatility if you are looking to be defensive other than that you should sim yourself to see which would be the largest dps upgrade for you.
Boots: Soul Treads - Useful for sire.
Weapon: Enchant Weapon - Sinful Revelation, Enchant Weapon - Celestial Guidance, Enchant Weapon - Lightless Force All 3 are viable options. Sinful is best for damage on single target, Lightless Force is best for damage on Cleave + AoE and Celestial Guidance is best for defence.
Similar to ring enchants you will gem for versatility if you are looking to be defensive and will sim yourself to find out which stats would be best for you offensively, otherwise.
Flasks: Spectral Flask of Power will be your go to choice for pretty much all content. Spectral Flask of Stamina can be used if you feel like you need a larger health pool to survive the content you are doing.
Weapon Oil: Shadowcore Oil
Food: Feast of Gluttonous Hedonism as your all around option. Steak a la Mode if you feel like you want to have a bit more versatility.
Armor Kit: Heavy Desolate Armor Kit.
Healing Potion: Spiritual Healing Potion.
Augment Runes: Veiled Augment Rune.